timing_card: get profile from structured flag #6465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdhollen
approved these changes
Apr 30, 2024
bduffany
reviewed
Apr 30, 2024
Currently we are assuming that the BuildToolLogs event will have relatively small amount of files that are uploaded via bytestream API. Using that assumption, we guessed that the build timing profile must be one of the 2 files referenced in this event, and differentiate them based on their file name. Detect the actual timing profile name by searching through canonical command line for a `--profile=` flag. If the user does not specify a custom profile name, assume the default `command.profile.gz` name.
Co-authored-by: Brandon Duffany <brandon@buildbuddy.io>
sluongng
force-pushed
the
sluongng/timing-profile-name-detect
branch
from
5d1696e
to
ebf5b91
Compare
iain-macdonald
added a commit
that referenced
this pull request
May 2, 2024
This reverts commit 3c25550.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are assuming that the BuildToolLogs event will have
relatively small amount of files that are uploaded via bytestream API.
Using that assumption, we guessed that the build timing profile must be
one of the 2 files referenced in this event, and differentiate them
based on their file name.
Detect the actual timing profile name by searching through canonical
command line for a
--profile=flag. If the user does not specify acustom profile name, assume the default
command.profile.gzname.