Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qwik showcase page has zooms in after scrolling to certain part #5881

Closed
bwmp opened this issue Feb 23, 2024 · 4 comments
Closed

Qwik showcase page has zooms in after scrolling to certain part #5881

bwmp opened this issue Feb 23, 2024 · 4 comments
Labels
COMMUNITY: good first issue Good for newcomers COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it COMP: docs Improvements or additions to documentation TYPE: bug Something isn't working

Comments

@bwmp
Copy link

bwmp commented Feb 23, 2024

2024-02-23.04-27-46.mp4

I dont know how else to describe it other that showing it or people trying it for themselves
@wmertens
Copy link
Member

wmertens commented Feb 23, 2024 •
edited

There's a thumbnail that 404s, https://qwik.dev/showcases/itbusinesshub_com_.webp, and as soon as that tries to load, all the images on the page become very wide.

It's as if the 404 causes some CSS constraint to be lifted.

@wmertens wmertens added TYPE: bug Something isn't working COMP: docs Improvements or additions to documentation COMMUNITY: good first issue Good for newcomers TYPE: showcase COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it labels Feb 23, 2024
@pleopardi
Copy link

There are three images missing: itbusinesshub_com_.webp, radixstream_com_.webp, andwww_anirbandas_in_.webp

Adding a width: "100%" to the img element on the showcase page should fix it nonetheless, I tried it live with the developer tools open.

I also wanted to open a PR but I have issues running the project for local development (some Rust dependencies requiring different versions), I may try again with more time to troubleshoot it.

@gioboa
Copy link
Member

gioboa commented Feb 24, 2024 •
edited

I'm recreating all the images with pnpm build.showcase script PR
Let's see if it solves the issue.

@gioboa
Copy link
Member

gioboa commented Feb 24, 2024

Thanks @pleopardi for your help. I added the missing images and now it's working fine.
Closed by #5889

@gioboa gioboa closed this as completed Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
COMMUNITY: good first issue Good for newcomers COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it COMP: docs Improvements or additions to documentation TYPE: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wmertens @pleopardi @gioboa @bwmp