[🐞] The behaviour of the cache has changed 1.5.0 (cloudflare) #5947
Comments
dejurin
added
STATUS-1: needs triage
|
The only commit I can think of that did something is this 1995753 - what seemed like a bugfix in that it waits until the SSR result completed to store the result to cache. Could that explain what you're seeing? I don't understand what you're suppposed to get in your repro. |
|
Actually you can verify if that's the commit by using the build from the commit before it - https://github.com/BuilderIO/qwik-build/tree/2c7014d476ba9223f1467aabbd8ddd23ff051fbf - see the instructions there. |
Thank you for response.
|
|
Can you try building with the link I gave you? |
So, I built. Work with a 15-seconds delay. https://ad8f1782.pwa-example-6dn.pages.dev/ Works the same as in version 1.5.0 https://ada7fe68.pwa-example-6dn.pages.dev/ |
|
Ok so it wasn't that commit then. Could you try building with previous commits after the 1.4.5 commit? You can binary search or just guess which commit might be the culprit based on the contents |
|
If I understand correctly, that's the 1995753 fix(cloudflare): wait to cache until response complete (#3679) reason |
|
Ok so you can confirm that the commit I gave you does not have the problem you're seeing in 1.5.0? |
yep, your commit b85761c fix(create-app): tmpdir handling (#5938) is work well. It does not affect the behavior of the cache. |
|
Wait that doesn't make sense at all, that commit comes after the commit that adds the cloudflare wait. It should fail. |
|
Rereading this, it looks like the one I gave you is indeed working and you accidentally gave me the commit after the broken commit as the fixed one. I will revert the waitUntil patch |
Which component is affected?
Qwik City (routing)
Describe the bug
After upgrading from 1.4.5 to 1.5.0 version, the cache stopped working as intended on cloudflare pages.
Headers - 1.4.5 with HIT
https://1-4-5.pwa-example-6dn.pages.dev/
Headers - 1.5.0
https://pwa-example-6dn.pages.dev/
An example of code that doesn't work as intended.
Reproduction
https://github.com/dejurin/pwa-example
Steps to reproduce
Deployment log
System Info
Hosting: Cloudflare Pages My system: System: OS: macOS 14.3.1 CPU: (11) arm64 Apple M3 Pro Memory: 106.17 MB / 18.00 GB Shell: 5.9 - /bin/zsh Binaries: Node: 18.19.1 - /opt/homebrew/opt/node@18/bin/node npm: 10.2.4 - /opt/homebrew/opt/node@18/bin/npm pnpm: 8.13.1 - /opt/homebrew/bin/pnpm bun: 1.0.30 - ~/.bun/bin/bun Browsers: Brave Browser: 121.1.62.165 Chrome: 122.0.6261.94 Edge: 122.0.2365.63 Safari: 17.3.1 npmPackages: @builder.io/qwik: ^1.5.0 => 1.5.0 @builder.io/qwik-city: ^1.5.0 => 1.5.0 undici: ^6.7.0 => 6.7.0 vite: ^5.1.5 => 5.1.5Additional Information
No response
The text was updated successfully, but these errors were encountered: