Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve actual version from git tag during build. #192

Closed
artem-zinnatullin opened this issue Mar 1, 2018 · 2 comments
Closed

Resolve actual version from git tag during build. #192

artem-zinnatullin opened this issue Mar 1, 2018 · 2 comments
Assignees
@artem-zinnatullin
Labels
enhancement
Milestone
v3.0.0

Comments

@artem-zinnatullin
Copy link
Contributor

Currently version is stored in project config which require us to update it manually and commit every time, we should get it from current git tag during build as we do for other projects like:

and others which allows us release new versions just by pushing new tag or through GitHub releases.
@artem-zinnatullin artem-zinnatullin added this to the v3.0.0 milestone Mar 1, 2018
@artem-zinnatullin artem-zinnatullin self-assigned this Mar 1, 2018
@artem-zinnatullin artem-zinnatullin mentioned this issue Mar 1, 2018
Merged
@artem-zinnatullin
Copy link
Contributor Author

Related: https://github.com/gojuno/mainframer/pull/191/files#r170609701

This was referenced Mar 1, 2018
Merged
Merged
@artem-zinnatullin
Copy link
Contributor Author

Closed by #203.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artem-zinnatullin artem-zinnatullin

Labels
enhancement
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
1 participant
@artem-zinnatullin