Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify units of numeric values #305

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Clarify units of numeric values #305

merged 2 commits into from
Jul 19, 2022

Conversation

ykulbak
Copy link
Collaborator

@ykulbak ykulbak commented Jul 19, 2022

GeorgDangl
GeorgDangl requested changes Jul 19, 2022
View reviewed changes
Copy link
Member

@GeorgDangl GeorgDangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just switched to Title Case here😀

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ykulbak @GeorgDangl
Apply suggestions from code review
cd29eae 
Co-authored-by: Georg Dangl <10274404+GeorgDangl@users.noreply.github.com>
@ykulbak
Copy link
Collaborator Author

ykulbak commented Jul 19, 2022

@GeorgDangl thanks. I've accepted your changes. Please squash before merging.

@ykulbak ykulbak requested a review from GeorgDangl July 19, 2022 10:55
@GeorgDangl GeorgDangl merged commit 17995d4 into release_3_0 Jul 19, 2022
@GeorgDangl GeorgDangl deleted the clarify-units branch July 19, 2022 11:03
GeorgDangl added a commit that referenced this pull request Sep 11, 2023
@GeorgDangl @ykulbak
Fix typo, and merge release_3_0 into master (#311)
3d75677 
* Add contributing information, see buildingSMART/BCF-XML#349 (#277)

* Clarify units of numeric values (#305)

* Update README.md

* Apply suggestions from code review

Co-authored-by: Georg Dangl <10274404+GeorgDangl@users.noreply.github.com>

Co-authored-by: Georg Dangl <10274404+GeorgDangl@users.noreply.github.com>

* Fix typo

---------

Co-authored-by: Yoram Kulbak <yoram.kulbak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgDangl GeorgDangl GeorgDangl approved these changes

@pasi-paasiala pasi-paasiala Awaiting requested review from pasi-paasiala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ykulbak @GeorgDangl