Update pass-a_classification_facet_with_no_data_matches_any_classific… #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation_2_2.ifc Removed one wall that was not being referenced by any IFCCLASSIFICATIONREFERENCE, which for me made the test case fail although it should pass. Any feedback appreciated if my thinking is not correct here.
|
Sorry this is an error in the spec generator, where the tests only check a single element. I've done a fix and will commit. This error will also affect other testcases, so don't worry about submitting PRs for them until I've committed the fix. |
|
Awesome thanks. I noticed there are a few more later on. I guess you could also have the 4th classification reference refer to the 4th wall instead of to IfcProject, I guess that's probably what was intented. |
|
Hey @Moult I looked at the new files, but for example this one seems to be wrong again, maybe I am too early? |
|
Sorry my bad, was working with stale IFC files, appreciate the fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ation_2_2.ifc
Removed one wall that was not being referenced by any IFCCLASSIFICATIONREFERENCE, which for me made the test case fail although it should pass. Any feedback appreciated if my thinking is not correct here.