Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IFC4 schema #101

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Added IFC4 schema #101

merged 1 commit into from
Oct 6, 2022

Conversation

rubendel
Copy link
Contributor

@rubendel rubendel commented Oct 6, 2022

Since the point of this test case (presumably) is to verify that the implementation detects that there are no IFCWALL in the IFC whilst the specification is REQUIRED, I think the spec should have the IFC4 ifcVersion otherwise it will already fail on that.

Since the point of this test case (presumably) is to verify that the implementation detects that there are no ```IFCWALL``` in the IFC whilst the specification is REQUIRED, I think the spec should have the ```IFC4``` ```ifcVersion``` otherwise it will already fail on that.
@berlotti
Copy link
Member

berlotti commented Oct 6, 2022

thank you!

@berlotti berlotti merged commit bea2a0d into buildingSMART:master Oct 6, 2022
@rubendel rubendel deleted the patch-3 branch October 6, 2022 13:01
@Moult
Copy link
Contributor

Moult commented Oct 7, 2022

I don't think this is right, I asked whether or not the ifcVersion should affect the pass/fail state, and the answer I was given was that it shouldn't, the ifcVersion is pure metadata. https://github.com/buildingSMART/IDS/blob/master/Documentation/testcases-ids.md#pass-specification-version-is-purely-metadata-and-does-not-impact-pass-or-fail-result

@rubendel
Copy link
Contributor Author

rubendel commented Oct 7, 2022

Hmm last time I was in a discussion about this that wasn't the case, but I have missed quite a few of the meeting lately.
A few reasons for making the IFC schema more significant:

  • Pre-check validation of IDS specs, for example non existing attributes, inverses, derived attributes, all of those require knowledge of the applicable schema(s).
  • When we added this to Specification (it was first in the Header) the idea was that you can have one IDS, that works for 2 different schemas, by having 2 specifications; one for schema X and one for schema Y. Logically they would check the same thing, but depending on the IFC schema, only one would be executed each time.

@Moult
Copy link
Contributor

Moult commented Oct 7, 2022

Maybe file a new issue so it can be discussed again?

@rubendel
Copy link
Contributor Author

rubendel commented Oct 7, 2022

Yes good idea

@rubendel rubendel mentioned this pull request Oct 7, 2022
@rubendel
Copy link
Contributor Author

rubendel commented Oct 7, 2022

#103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants