Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bf: IfcWall #4 must have classification to pass pass-occurrences_over… #226

Closed
wants to merge 3 commits into from

Conversation

I-Sokolov
Copy link
Contributor

…urrences_override_the_type_classification_per_system...
@andyward
Copy link
Contributor

andyward commented Dec 11, 2023

Hi Igor, I think the issue is these test cases are generated in the IfcOpenShell repo so we can't patch then here without getting over-written in future.

I think the root cause is that the IfcOpenShell method that generates these IDS and IFC files

  1. introduces an IfcWall in the model for one set of tests as element0 - element # 4
  2. then introduces a second instance of IfcWall as wall and the first wall conflicts. (ends up as Element # 18)

Ideally these test cases would be cleaned up a bit, but a quick fix would be to change element0 to be some other type e.g. IfcDoor, so it won't conflict.

Also raises the question that there may be an issue in the IfcOpenShell validator or test-suite if the tests are not picking this up? Pinging @Moult as I think he wrote them?

@andyward andyward mentioned this pull request Dec 12, 2023
@I-Sokolov I-Sokolov closed this Dec 21, 2023
@I-Sokolov I-Sokolov deleted the master branch December 21, 2023 14:03
@andyward andyward mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants