Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC001 #31

Merged
merged 77 commits into from
May 23, 2023
Merged

BC001 #31

merged 77 commits into from
May 23, 2023

Conversation

BenzclyZhang
Copy link
Contributor

This PR has three test cases:

  • PS01
  • TE01
  • AL01

<PI>1253161.285036 2692254.060858</PI>
<End>1253147.355411 2692313.559244</End>
</Spiral>
<Spiral length="82.488820" radiusEnd="2600.000000" radiusStart="2600.000000" rot="ccw" spiType="clothoid" constant="0.000000" dirEnd="4.5141308569" dirStart="4.4824043877" theta="0.0317264692" totalY="1.308430" totalX="-82.474982" staStart="13946.345000" tanLong="41.247870" tanShort="41.247870">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can the start radius and the end radius be the same for a transition spiral?
radiusEnd="2600.000000" radiusStart="2600.000000"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenzclyZhang can you please check this out? Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This segment is wrong. It is removed.

@evandroAlfieri evandroAlfieri merged commit 14d88d8 into buildingSMART:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants