Val445 pse001 refinements 2 #191
Conversation
features/steps/thens/relations.py
Outdated
| accepted_values['predefined_types'] = sorted(set(s.upper() for s in accepted_values['predefined_types'])) | ||
|
|
||
| # @todo this is actually wrong, we should consider pairs of <entity, predefined type> together | ||
| # and not separately. But in the majority of cases this will be good enough. |
There was a problem hiding this comment.
I'm thinking of a way to handle this, e.g.
Scenario Outline:
Given an <IfcEntity>
Given its PropertySet
Then the value must be one of <X>
#or The value must be in <Y>
Examples:
Entity | X
EntityA | Value1,Value2,Value3
EntityB | Value4, Value5, Value6
EntityC | Value7, Value8, Value9
#or
Entity A | AllowedPredefinedTypesX
Entity A | AllowedPredefinedTypesY
Perhaps at least for the ones for which errors are most likely to occur (to our knowledge) and exclude them from .
Or we can do it the other way around and be more restrictive at
if 'IfcPropertySet Name attribute value must use predefined values according' in context.step.name:
if name not in property_set_definitions.keys():
yield ValidationOutcome(inst=inst, observed = {'value':name}, severity=OutcomeSeverity.ERROR)
and defined specific psets for values (in a separate csv) for the inverse of inst (which is a pset)?
context.model.get_inverse(inst)
So for IfcWall, that would be one of the following values;
https://ifc43-docs.standards.buildingsmart.org/IFC/RELEASE/IFC4x3/HTML/lexical/IfcWall.htm#6.1.3.41.5-Property-sets
There was a problem hiding this comment.
I do like the idea to offload more of the python code to gherkin to make it more explicit. Especially the predefined type handling is now fully opaque in gherkin. It would be nice if we have a specific statement for that. Also filtering on whether the predefined type is required and/or present.
Co-authored-by: Geert Hesselink <54070862+Ghesselink@users.noreply.github.com>
Co-authored-by: Geert Hesselink <54070862+Ghesselink@users.noreply.github.com>
Co-authored-by: Geert Hesselink <54070862+Ghesselink@users.noreply.github.com>
Co-authored-by: Geert Hesselink <54070862+Ghesselink@users.noreply.github.com>
No description provided.