-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OJP001 - Relative placement for elements aggregated to another element #27
Merged
aothms
merged 13 commits into
main
from
ojp001_relative-placement-for-elements-aggregated-to-another-element
Feb 2, 2023
Merged
OJP001 - Relative placement for elements aggregated to another element #27
aothms
merged 13 commits into
main
from
ojp001_relative-placement-for-elements-aggregated-to-another-element
Feb 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aothms
requested changes
Dec 29, 2022
pjanck
suggested changes
Dec 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial comments and questions.
features/OJP001_Relative-placement-for-elements-aggregated-to-another-element.feature
Outdated
Show resolved
Hide resolved
…gated-to-another-element # Conflicts: # features/steps/steps.py
aothms
approved these changes
Jan 26, 2023
…ment-for-elements-aggregated-to-another-element # Conflicts: # features/steps/steps.py
…gated-to-another-element
Blergh more merge conflicts. But I think they were all just side by side inserts so I quickly resolved them. Maybe @JTurbakiewicz you can have a quick double check. |
Looks good I think. :) |
Ghesselink
deleted the
ojp001_relative-placement-for-elements-aggregated-to-another-element
branch
November 1, 2023 10:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.