Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass-the_container_may_be_indirect, should it really pass? #227

Closed
I-Sokolov opened this issue Dec 13, 2023 · 2 comments · Fixed by #287
Closed

pass-the_container_may_be_indirect, should it really pass? #227

I-Sokolov opened this issue Dec 13, 2023 · 2 comments · Fixed by #287
Assignees
Labels
Milestone

Comments

@I-Sokolov
Copy link
Contributor

The IDS requires partOf with relation="IfcRelContainedInSpatialStructure".

In the IFC mode the beam is aggregated into slab and slab is contained in space.

As documentation says, "only the specified relation type should be considered (also recursively)" - the beam does not fit to this requirement.

Semantically it should, so I assume documentation needs special case and clarification for spatial containment.

@CBenghi CBenghi added the tests label Mar 6, 2024
@CBenghi CBenghi added this to the 1.0 milestone Mar 6, 2024
@CBenghi
Copy link
Contributor

CBenghi commented Apr 26, 2024

Hi @I-Sokolov,
you are right, we need to change this test to be a fail.
Probably also add another leaving the relation empty and that should be a pass (on the same IFC file).

@CBenghi CBenghi self-assigned this Apr 26, 2024
@CBenghi
Copy link
Contributor

CBenghi commented Apr 26, 2024

@atomczak,
you are also right we that we need to add another test case for multiple relations of the same type.

atomczak added a commit to atomczak/IDS that referenced this issue May 2, 2024
CBenghi added a commit to CBenghi/IDS that referenced this issue May 3, 2024
@CBenghi CBenghi linked a pull request May 3, 2024 that will close this issue
@CBenghi CBenghi closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants