[Feature] #1
[Feature] #1
Conversation
patch-lee
commented
Jan 11, 2021
patch-lee
commented
- Added display date format for input
- Added clearable props to let user clear thier selected date
- Added inputStyle to control input box styling
|
@buildingwatsize I passed by and I noticed some missing features, so I have updated displayFormat and clearable feature for your datepicker, please review and merge if it works fine. |
|
@patch-lee, Thank you for your PR, After trying out the review features, I liked your idea of making a display format (which doesn't affect the value of input), but PR's code seems to be limited to formats that only support dD, mM, yY. I just figured out that format what I want is also in a labeling date, such as "จันทร์, 11 มกราคม 2564". I should also support that stuff for the display formatting to be perfect. So I would like to implement this to the dayjs's formatting. You can re-check how to use which contains in README.md and also Online Demo on GitHub Pages. At the same time, I agree with the features of clearable flag and custom style, and I just released a new version in v0.1.3. It's my honor to have you contribute to my code. Have a good day. |
|
It's also my honor to help contribute to this great repo :) I think it might help someone who is struggling with react + ant design + thai format (eg. Me) LOL At first, I have considered to use dayjs with buddhistEra plugin to format the display value but I'm not sure that it will effect some feature (such as moment support) since it's available only to dayjs. Also I need to fix the display of antd datepicker display in my project within no time so I have to manage to fix this real quick, so it ended up with that rough solution sorry for that too :( Thank you for considering my PR, I have a good day now. |
