Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cdn_publish.sh): only publish to CDN for gravit-ui-web changes #242

Merged
merged 2 commits into from May 1, 2019

Conversation

thehammeranderson
Copy link
Contributor

ISSUES CLOSED: #235

Description
Only publish to CDN if gravity-ui-web source changes are committed

Copy link

@james-nash james-nash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One teeny change, but otherwise it looks good to me. Thanks!

scripts/cdn_publish.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@dw-buildit dw-buildit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions

scripts/cdn_publish.sh Outdated Show resolved Hide resolved
scripts/cdn_publish.sh Outdated Show resolved Hide resolved
scripts/cdn_publish.sh Outdated Show resolved Hide resolved
scripts/cdn_publish.sh Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
Copy link

@james-nash james-nash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thehammeranderson thehammeranderson dismissed ashblue’s stale review May 1, 2019 15:43

I removed changes to .gitignore that was requested

@thehammeranderson thehammeranderson merged commit 9b59056 into develop May 1, 2019
@james-nash james-nash deleted the cdn_publish_change_filter branch May 7, 2019 12:47
@buildit-dev
Copy link

🎉 This PR is included in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@buildit-dev buildit-dev added the released STATUS: This change has been released. label Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released STATUS: This change has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make CDN publish script bail out for non-CDN published packages
5 participants