Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ulimits support #218

Merged
merged 4 commits into from
Sep 29, 2022
Merged

Add ulimits support #218

merged 4 commits into from
Sep 29, 2022

Conversation

francoiscampbell
Copy link
Contributor

Adds support for docker run --ulimit (https://docs.docker.com/engine/reference/commandline/run/#set-ulimits-in-container---ulimit) under the ulimits: plugin option.

Tested with a local pipeline:
Screen Shot 2022-09-27 at 3 41 06 PM
Screen Shot 2022-09-27 at 3 41 52 PM

ulimit -a output:
Screen Shot 2022-09-27 at 3 21 20 PM

toote
toote approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@toote toote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution! If you add tests we'll be happy to re-review this and merge it!

(while you are at it if you want to push the Readme version to 5.2.0 it would leave everything ready for the next contributor)

@francoiscampbell
Copy link
Contributor Author

Thanks @toote, added tests and bumped the readme versions

@toote toote merged commit 8d3d7e3 into buildkite-plugins:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toote toote toote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@francoiscampbell @toote