Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A pull option for run to allow multiple services to be pulled #109

Merged
merged 3 commits into from
Apr 3, 2018

Conversation

lox
Copy link
Contributor

@lox lox commented Mar 7, 2018

This adds a top-level pull property that is used with run to indicate you want to pull down multiple services. If any of them are prebuilt in a previous step, they will be pulled down.

steps:
  - name: ":docker: Build"
    plugins:
      docker-compose#master:
        build: 
          - app
          - app_dependency
        image-repository: index.docker.io/org/repo

  - wait

  - name: ":docker: Test"
    plugins:
      docker-compose#master:
        run: app
        pull: 
          - app_dependency

This will probably merit a bump to 2.0.0.

Closes #96 and #86.

@lox lox added the wip label Mar 7, 2018
@grrowl
Copy link

grrowl commented Mar 15, 2018

Tested (as docker-compose#add-pull-option on a v3.0-beta.39 agent) with one service under pull:. Works a charm, running a docker-compose ... pull <service> command and displaying the output (and the exit code)

@lox
Copy link
Contributor Author

lox commented Mar 15, 2018

Really appreciate that @grrowl!

@lox lox removed the wip label Mar 20, 2018
@lox lox requested a review from toolmantim March 20, 2018 21:30
@lox lox merged commit ce444a6 into master Apr 3, 2018
@lox lox deleted the add-pull-option branch April 3, 2018 23:31
@grrowl
Copy link

grrowl commented Apr 4, 2018

Hi, are we cutting a new release for docker-compose-buildkite-plugin@1.8.5 with this code included? Our pipeline references plugins: docker-compose#add-pull-option, and deleting the branch here halted our pipeline :\

@lox lox restored the add-pull-option branch April 4, 2018 04:27
@lox
Copy link
Contributor Author

lox commented Apr 4, 2018

I didn't even think of that, sorry @grrowl!!! I've restored the branch.

We will cut a 2.0.0 release likely, as there have been some other changes in master that merit it.

@chriwu
Copy link

chriwu commented Apr 4, 2018

Awesome work - thank you Buildkite! 😍 🎉

@toolmantim
Copy link
Contributor

v2.0.0 is now out, and the readme’s been updated too 🎉

@toote toote deleted the add-pull-option branch May 23, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants