New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying the --no-deps flag #117
Conversation
This seems very reasonable. I'm pretty in favor of adding most of the |
We'll also have a think about this! Reckon that's a bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @tessereth! Looks great.
@lox yeah, I reckon we should support all of the flags! |
@toolmantim Should we implement them all as top level options, or add a compose_args option that passes them directly through? |
@lox top level options is nicer for the end-user, and the pipeline.yml, so I say that's worth the technical cost? |
Agreed! |
(there's a only a couple more to add, as some don't make sense like |
Sweet, thanks for merging this! |
Thank you very much for your contribution @tessereth, we will get this into the next version 🙌🏻 |
I'm currently trying to migrate my buildkite pipeline to use the new plugin system but I've run into a little snag. I have some steps that require a bunch of dependent services but some steps that do not. I tried using the docker plugin for the steps that don't need the services but the docker plugin makes some assumptions that don't work in my case^. Given I have a docker compose file anyway and I'm using it for the other steps, it would be convenient for me to use the docker-compose plugin for everything but specify the
--no-deps
flag somehow. I'm not fussed how that option gets set but given I made this change to confirm this solved my problem, I figured I'd make a PR rather than just an issue.^ For completeness, the docker plugin always specifies the
--workdir
commandline flag, overriding the default I set in myDockerfile
and mounts the pwd at that directory which I also don't want. My source code is already inside the image that I prebuilt in a previous step. Theoretically changes could be made on the docker plugin to solve my problem as well but this seems cleaner.