Allow docker container creation during run to also receive build options #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolmantim
force-pushed
the
allow_build_params_run
branch
from
78c9ecd
to
22b3719
Compare
|
Thanks @derekju, and sorry for the delay. I added some tests, and updated the readme, and this is good to go 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it handy that I could define a step to run a command on a docker container without the pre-requisite of having that container pre-built already. However, the underlying
docker-composedoesn't receive the same support for the plugin options that are only limited to thebuildrun type.I specifically wanted the ability to specify
ARGSso I lifted the code from thebuild.shcommand and dropped it in to theruncommand. This also allows for the--no-cacheand--paralleloptions to be passed on as well.My bash-fu isn't that great so not sure if there is a better way to DRY this up instead of copying & pasting but wanted to see if this was an acceptable idea.