Copy docker plugin's mount-ssh-agent feature #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puyo
changed the title
|
Hey @puyo! Thank you for your contribution! I'm hoping we can soon review it and we'll keep you posted 🙏🏻 |
|
@puyo Build was failing due to environment variable in pipeline using git:// url which is no longer supported by Github. We have rolled out a fix for this so please can update the PR with any change so a build will be triggered and we can have a successful build for the PR. As I do not have permissions to your branch to make changes, I would need you to do that to trigger a build. Once build is successful we should be good to merge this PR |
|
@puyo Thank you for your contributions. PR is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, love your work,
That
mount-ssh-agentfeature in thedockerplugin means we canbundle installour Rails apps that have git/github references in theirGemfiles. It's very handy! However, some of our repos also need databases, redis, or other services to run their test suites, so they have to run withdocker-composeto spin them up. However,docker-compose"run" is mysteriously lackingmount-ssh-agent, so I copied it over and now it works swimmingly for us.Not sure how you feel about merging this in, but I thought I'd open the PR and offer it up anyways.
Take care!