-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add labels to run container #376
Add labels to run container #376
Conversation
This is a great addition! 👏 I would indeed add it behind a configuration, but have it on by default... the reason is two-fold: |
Thanks for the feedback @toote, made it conditional (default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment and a cosmetic suggestion.
If you feel like making the changes, I would also suggest updating the plugin's versions in the readme with the next one (v4.11.0
) to avoid having to create another PR in the future. But there is no hurry or need and we might merge and release this plugin without that change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Adds labels that can be useful for finding the containers spawned on a host by this plugin. This can also enable automated tools to associate these docker-compose containers with the agent that started them.
Tested on our infra:
Question for maintainers: should this be behind a plugin config? I don't think so since it doesn't affect the behaviour of the container itself, but I'm happy to make it conditional if needed.