Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ssh option in builds #383

Merged
merged 4 commits into from
Apr 10, 2023
Merged

Fix ssh option in builds #383

merged 4 commits into from
Apr 10, 2023

Conversation

toote
Copy link
Contributor

@toote toote commented Apr 4, 2023

Corrects the misuse of the ssh option allowing it to be specified as a string and use default if set to true

Closes #382

@toote toote added the bug label Apr 4, 2023
@toote toote requested a review from pzeballos April 4, 2023 18:43
@pzeballos pzeballos merged commit 1d9c570 into master Apr 10, 2023
@pzeballos pzeballos deleted the toote_fix_ssh_issue-382 branch April 10, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzeballos pzeballos pzeballos approved these changes

@jklafka-rokt jklafka-rokt jklafka-rokt approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSH passed as boolean instead of string to docker-compose
3 participants
@toote @pzeballos @jklafka-rokt