Add skip-pull support to build phase #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supaspoida
force-pushed
the
skip-pull-build
branch
2 times, most recently
from
33efad9
to
f1491b4
Compare
toote
requested changes
Apr 8, 2023
There was a problem hiding this comment.
Great work!
Only one thing missing: adding build to the dependency for the new option
README.md
Outdated
| @@ -486,7 +486,7 @@ Whether to skip the repository checkout phase. This is useful for steps that use | |||
|
|
|||
| **Important**: as the code repository will not be available in the step, you need to ensure that the docker compose file(s) are present in some way (like using artifacts) | |||
|
|
|||
| ### `skip-pull` (optional, run only) | |||
| ### `skip-pull` (optional) | |||
There was a problem hiding this comment.
It should be build and run only (as it wouldn't apply to the push)
There was a problem hiding this comment.
Ah thanks, fixed in latest!
supaspoida
force-pushed
the
skip-pull-build
branch
from
f1491b4
to
ddb41c5
Compare
Reuses the existing `skip-pull` option to conditionally remove the `--pull` flag from the generated docker compose command.
supaspoida
force-pushed
the
skip-pull-build
branch
from
ddb41c5
to
c8a6cde
Compare
toote
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuses the existing
skip-pulloption to conditionally remove the--pullflag from the generated docker compose command.I have a use case where I am pre-building images outside the docker-compose plugin and wanted to use those images in the
FROMtag of aDockerfileto be built via the plugin. With the--pullflag docker compose tries to fetch from docker hub and fails. This change puts the flag behind the sameSKIP_PULLconditional currently used bythe run phase.
I verified that this works as expected for my own pipelines but those are very simple at the moment and not exercising much of the plugin's surface area. If there are explicit reasons why this was unsupported previously I'm happy to revisit this approach or come up with another workaround.