Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env-propagation-list: programmatically propagate envvars to the container #388

Merged

Conversation

amartani
Copy link
Contributor

@amartani amartani commented May 5, 2023

Implements the same feature as buildkite-plugins/docker-buildkite-plugin#238, which is also useful for docker-compose use case. See the linked PR for rationale / use cases.

Copy link
Contributor

@toote toote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment on the documentation, but also the tests should be added when compose is run as a docker plugin instead of a standalone executable (in the file tests/v2/run.bats)

README.md Outdated Show resolved Hide resolved
amartani and others added 3 commits May 6, 2023 12:06
Co-authored-by: Matías Bellone <toote@users.noreply.github.com>
@amartani
Copy link
Contributor Author

amartani commented May 6, 2023

Just a minor comment on the documentation, but also the tests should be added when compose is run as a docker plugin instead of a standalone executable (in the file tests/v2/run.bats)

Added tests for tests/v2/run.bats; PTAL.

@amartani amartani requested a review from toote May 6, 2023 19:51
@toote toote merged commit 7d2363c into buildkite-plugins:master May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants