Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buildkite inline cache env #428

Merged
merged 4 commits into from Feb 23, 2024

Conversation

jquick
Copy link
Contributor

@jquick jquick commented Feb 23, 2024

It's possible to set this via the args config property. However, when trying to define it as global default with

BUILDKITE_PLUGIN_DOCKER_COMPOSE_ARGS_0="BUILDKIT_INLINE_CACHE=1"

you can end up accidentally overwriting args provided in a pipeline.yml.

Providing a separate config property allows you to set it via an env var
while avoiding overwriting any provided args.

Use Case

We build a lot of images and usually have our users setup their own pipelines. As owners we want to ensure that every image is built with inline cache.

Signed-off-by: Jared Quick <jared.quick@salesforce.com>
Signed-off-by: Jared Quick <jared.quick@salesforce.com>
Signed-off-by: Jared Quick <jared.quick@salesforce.com>
Signed-off-by: Jared Quick <jared.quick@salesforce.com>
Copy link
Contributor

@toote toote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 how did we not think of this? 👏

Copy link
Contributor

@pzeballos pzeballos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jquick! 🙌🏻 this looks very good! and thanks for fixing the tests :P

@pzeballos pzeballos merged commit 8d5db9f into buildkite-plugins:master Feb 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants