Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUP-1248: Use process substitution to hide auth token #64

Merged
merged 4 commits into from Jan 9, 2024
Merged

SUP-1248: Use process substitution to hide auth token #64

merged 4 commits into from Jan 9, 2024

Conversation

tomowatt
Copy link
Contributor

@tomowatt tomowatt commented Jan 8, 2024

Using process substitution allows using environment variables without exposing them through ps

@tomowatt tomowatt marked this pull request as draft January 8, 2024 11:10
@tomowatt tomowatt marked this pull request as ready for review January 8, 2024 14:05
pzeballos
pzeballos approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@pzeballos pzeballos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@tomowatt tomowatt merged commit b0caed3 into main Jan 9, 2024
1 check passed
@tomowatt tomowatt deleted the SUP-1248 branch January 9, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzeballos pzeballos pzeballos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomowatt @pzeballos