Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add job label to message and amend annotation. #66

Merged
merged 3 commits into from Feb 5, 2024
Merged

Add job label to message and amend annotation. #66

merged 3 commits into from Feb 5, 2024

Conversation

jtszalay
Copy link
Contributor

Hello! This fixes #65 . Here's an example pipeline with the change:

Screenshot 2024-01-16 at 1 44 48 PM

toote
toote requested changes Feb 3, 2024
View reviewed changes
Copy link
Contributor

@toote toote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! Can you fix the tests so that we can merge and release it?

@jtszalay jtszalay changed the title Add job label to message and ammend annotation. Add job label to message and amend annotation. Feb 4, 2024
@jtszalay
Copy link
Contributor Author

jtszalay commented Feb 4, 2024

@toote Tests fixed! Thanks!

@jtszalay jtszalay requested a review from toote February 4, 2024 02:49
pzeballos
pzeballos reviewed Feb 5, 2024
View reviewed changes
hooks/pre-exit Outdated Show resolved Hide resolved
pzeballos
pzeballos approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@pzeballos pzeballos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtszalay! I'll do a release later in the day :)

@pzeballos pzeballos merged commit b5323d9 into buildkite-plugins:main Feb 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toote toote toote approved these changes

@pzeballos pzeballos pzeballos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If multiple steps use the plugin the step that runs last will be the only context reported.
3 participants
@jtszalay @toote @pzeballos