3.x Agent Bootstrap fails silently when BUILDKITE_CLEAN_CHECKOUT is truthy

[plasticine]

Running buildkite-agent bootstrap will fail silently when the BUILDKITE_CLEAN_CHECKOUT env var is set.

I’ve replicated against beta.34, purely via curl-ing a build ENV from the api and invoking buildkite-agent bootstrap.

Context: https://buildkitechat.slack.com/archives/C02T53V9H/p1510043322000137

[lox]

Hrm, perplexing. We have a specific test for that:

agent/bootstrap/integration/checkout_integration_test.go

Line 184 in 2b2fe71

func TestForcingACleanCheckout(t *testing.T) {

I wonder what is going on.

[lox]

I'm struggling to reproduce this one @plasticine, I'm running:

BUILDKITE_CLEAN_CHECKOUT=true buildkite-agent bootstrap --job "llamas" --repository "git@github.com:buildkite/agent.git" --debug --commit "HEAD" --branch "master" --agent "my-agent" --organization "buildkite" --pipeline "agent" --pipeline-provider git --build-path /usr/local/var/buildkite-agent/builds

Could you provide the output of that?

[plasticine]

@lox OK, in repro-ing this I’ve found the actual cause. We actually have BUILDKITE_CLEAN_CHECKOUT=set for some reason. Everything works perfectly if BUILDKITE_CLEAN_CHECKOUT=true.

[lox]

Awesome, that's a good outcome, you can correct that and I can fix the bug :)

[plasticine]

@lox Yep — yay! 💯 Interestingly BUILDKITE_CLEAN_CHECKOUT=set ./bin/buildkite-agent bootstrap --build-path builds actually exits zero too FYI.

[lox]

urfave/cli#610