Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the port be made optional in BUILDKITE_METRICS_DATADOG_HOST? #868

Closed
yob opened this issue Dec 10, 2018 · 1 comment
Closed

Can the port be made optional in BUILDKITE_METRICS_DATADOG_HOST? #868

yob opened this issue Dec 10, 2018 · 1 comment

Comments

@yob
Copy link
Contributor

yob commented Dec 10, 2018

We've just upgraded a few agents to 3.6.0 and tried out the datadog integration.

One thing that caught us out is the BUILDKITE_METRICS_DATADOG_HOST env var requires a port (ie x.x.x.x:8125, not x.x.x.x). Leaving it off is a fatal error. Port 8125 is the default port for dogstatsd - could the port be made optional?

It's not a huge issue, but for those on GKE (like us) it requires some gymnastics to work around and might be confusing for anyone new to kube. For reference, we were able to insert the port using interpolation in env vars:

            env
            - name: BUILDKITE_METRICS_DATADOG
              value: "1"
            - name: DATADOG_HOST
              valueFrom:
                fieldRef:
                  fieldPath: status.hostIP
            - name: BUILDKITE_METRICS_DATADOG_HOST
              value: "$(DATADOG_HOST):8125"
@lox
Copy link
Contributor

lox commented Dec 16, 2018

Sounds super sensible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants