Allow signal agent sends to bootstrap on cancel to be customized #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @lox, glad to see this coming. Did we add configurable timeout duration already or is that still TBD? |
|
@DazWorrall |
keithpitt
approved these changes
Jul 29, 2019
GaryPWhite
added a commit
to GaryPWhite/docs
that referenced
this pull request
Oct 21, 2019
buildkite/agent#1041 noted that there was a duplicate of `BUILDKITE_CANCEL_GRACE_PERIOD` -- putting a proper definition for `BUILDKITE_CANCEL_SIGNAL`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the agent sends a
SIGTERMto the bootstrap on user cancellation of a job.This adds
cancel-signalwhich accepts signals in the form ofSIGTERM,SIGHUP, etc.The default will remain
SIGTERMuntil the next major version and then it will beSIGINT./cc @DazWorrall