Propagate signals in intermediate bash shells #1116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you execute multiple commands, e.g:
then we join them together in a single bash shell as
/bin/bash -e -c './process1\b./process2
, which has the side effect of creating an intermediate shell in between the bootstrap process and your commands. By default, most shells won't automatically propagate signals to subprocesses, so when the job is cancelled the signal gets lost in this intermediate shell.This could be manually fixed by adding a trap as the first command:
That ends up kind of noisy and for those not versed in shell voodoo, confusing.
This PR automatically adds this into non-script commands.