Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: windows tests on queue=buildkite-agent-windows without Docker #1294

Merged
merged 3 commits into from
Sep 20, 2020

Conversation

pda
Copy link
Member

@pda pda commented Sep 11, 2020

This pull request relates to the CI pipeline for this buildkite/agent codebase itself.

Run the Windows tests for this codebase directly on the agent machine, not via docker, using a nightly custom AMI produced by buildkite/image-builder.

Pulling and configuring the ~1.5GB mcr.microsoft.com/windows/servercore Docker image was very slow, and added a layer of indirection making it slightly harder or more complex to debug test failures.

  • Windows tests now run directly on the agent.
  • The Windows-specific Dockerfile and docker-compose configuration are deleted.
  • A new queue=buildkite-agent-windows is targeted.
  • .buildkite/image-builder/bootstrap.ps1 customises the windows AMI used to run these tests

@pda pda merged commit e99cae5 into master Sep 20, 2020
@pda pda deleted the ci-windows-tests-overhaul branch September 20, 2020 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant