Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang from 1.17.6 to 1.18 #1603

Merged
merged 3 commits into from
Apr 22, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 1, 2022

Bumps golang from 1.17.6 to 1.18.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file docker labels Apr 1, 2022
dependabot bot and others added 3 commits April 21, 2022 17:25
Bumps golang from 1.17.6 to 1.18.0.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
- Remove instructions for if the agent is cloned to GOPATH - these instructions aren't relevant for any recent version of go
- Add a note saying what version of go we use explicitly
- Add a note making explicit that compiling the agent with Go < 1.18 might not work
@moskyb moskyb force-pushed the dependabot/docker/dot-buildkite/golang-1.18.0 branch from 1808fa8 to ac4001c Compare April 21, 2022 05:25
@moskyb moskyb requested review from pda and a team April 21, 2022 05:26
@moskyb
Copy link
Contributor

moskyb commented Apr 21, 2022

Having Go 1.18 features would be a huge win - i'm really keen on generic collection functions, the any keyword predeclared identifier, and test fuzzing would be awesome to have in the agent.

@moskyb moskyb changed the title Bump golang from 1.17.6 to 1.18.0 in /.buildkite Bump golang from 1.17.6 to 1.18 Apr 21, 2022
Comment on lines +33 to +36
)

require (
github.com/cpuguy83/go-md2man/v2 v2.0.0-20190314233015-f79a8a8ca69d // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This split happened as a result of running go mod tidy using go 1.18 - it splits the direct dependencies up from the indirect ones

Copy link
Member

@pda pda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me 👍🏼

@moskyb moskyb merged commit 283b7c2 into main Apr 22, 2022
@moskyb moskyb deleted the dependabot/docker/dot-buildkite/golang-1.18.0 branch April 22, 2022 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants