Log levels #1635
Merged
Log levels #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sj26
reviewed
May 13, 2022
sj26
reviewed
May 13, 2022
moskyb
force-pushed
the
log-levels
branch
2 times, most recently
from
f140411
to
5695227
Compare
This required rejigging the config loading a little bit, but this is now done in line with the way that buildkite-agent start does it
This was referenced May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Problem: Some of the time, users of the buildkite-agent might not necessarily want or need all of the logs we're spitting out, either for cost reasons (storing logs can get pricy) or for readability reasons (i don't necessarily care about everything the agent is doing all the time.
✅ Solution: Add a cli flag,
--log-leveland an accompanying envarBUILDKITE_AGENT_LOG_LEVEL, to set the level of the logger on the agent. Now, if I set--log-level error, the buildkite agent logger will only output logs of level error or higher. This flag is enabled for all CLI commands, exceptbootstrap.This PR is best read commit-by-commit.