Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update log-level description #1676

Merged
merged 2 commits into from Jun 20, 2022
Merged

Conversation

pzeballos
Copy link
Contributor

@pzeballos pzeballos commented Jun 17, 2022

The description from the docs around the the -log-level option doesn't include the rest of the possibles values: https://buildkite.com/docs/agent/v3/cli-pipeline#options
This was raised by a customer.

That doc section gets automatically generated from this code.
I'm adding the rest of the possibles values according to https://github.com/buildkite/agent/blob/main/logger/level.go#L19

The description from the docs around the the `-log-level` option doesn't include the rest of the possibles values: https://buildkite.com/docs/agent/v3/cli-pipeline#options
That doc section gets automatically generated from this one.
I'm adding the rest of the possibles values according to https://github.com/buildkite/agent/blob/main/logger/level.go#L19
Copy link
Contributor

@moskyb moskyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! one minor nit, feel free to change or not

clicommand/global.go Outdated Show resolved Hide resolved
Change the wording to be more in line with the language used elsewhere

Co-authored-by: Ben Moskovitz <ben@mosk.nz>
@moskyb moskyb merged commit 6890e37 into main Jun 20, 2022
@moskyb moskyb deleted the update-docs-around-log-level-values branch June 20, 2022 02:10
ddbeck added a commit to buildkite/docs that referenced this pull request Jun 22, 2022
This rolls up changes from the following PRs:

- buildkite/agent#1676
- buildkite/agent#1672
- buildkite/agent#1515 (round-tripping #1128)

The two more recent changes are actually ahead of the currently-released
agent text, but they're strictly docs changes, so they don't reflect
anything that isn't already true in the release version of the agent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants