Reverse error checking logic to make sure lock errors are logged #1689
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this potential issue while reading through this code. Due to how the flock library will set always return (false, err) this code wouldn't print other lock errors since it would always hit the first branch. This flips the logic to make sure the err is checked first then falls through when the more typical case of the lock being held by someone else most of the time. gofrs/flock will never return (true, err): https://github.com/gofrs/flock/blob/master/flock_unix.go#L158