retry 5xx responses when attempting to start a job #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moskyb
reviewed
Oct 6, 2022
We occasionally see 502 responses from the Agent API when starting a job. Since those responses likely indicate a transient issue, I think it makes sense to attempt to retry those and other 5xx responses for this call rather than failing and having the job be re-scheduled.
moskyb
force-pushed
the
retry-server-errors-for-startjob
branch
from
a627fea
to
6e01873
Compare
moskyb
approved these changes
Oct 10, 2022
|
awesome work @jonahbull! thanks so much ^_^ |
|
Thanks @moskyb! Appreciate your quick and helpful feedback 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We occasionally see 502 responses from the Agent API when starting a job:
Since those responses likely indicate a transient issue, I think it makes sense to attempt to retry those and other 5xx responses for this call rather than failing and having the job be re-scheduled. Open to any suggestions or input y'all might have.