Add option to set the service name for tracing #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the addition of OpenTelemetry, the name changed to buildkite-agent (dash instead of underscore). I'd like to keep the underscore to retain continuity with our historical data.
triarius
reviewed
Nov 22, 2022
There was a problem hiding this comment.
Hi @goodspark thanks for the PR! Apologies for taking so long to review it, but if you agree with the suggestion, we should be able to get this merged quickly.
Co-authored-by: Narthana Epa <narthana.epa@gmail.com>
triarius
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
Thanks @goodspark I've started a build. We should be able to merge this once that's done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the addition of OpenTelemetry, the name changed to buildkite-agent (dash instead of underscore). I'd like to keep the underscore to retain continuity with our historical data.