Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update launchd templates to use .buildkite-agent dir #212

Merged
merged 1 commit into from Nov 12, 2015

Conversation

julianwa
Copy link
Contributor

@toolmantim
Copy link
Contributor

Thanks for the catch here!

toolmantim added a commit that referenced this pull request Nov 12, 2015
Update launchd templates to use .buildkite-agent dir
@toolmantim toolmantim merged commit fba7056 into buildkite:master Nov 12, 2015
@julianwa
Copy link
Contributor Author

NP. Should also update these docs:

https://buildkite.com/docs/agent/osx#starting-on-login

s/LaunchAgent/LaunchAgents/
s/.buildkite/.buildkite-agent/

@toolmantim
Copy link
Contributor

Thanks! I've just fixed those in buildkite/docs@a2570cd and buildkite/docs@a2570cd, and it's been updated on https://buildkite.com/docs/agent/osx - let me know if that all looks good 👍

@julianwa
Copy link
Contributor Author

LGTM, thanks! (Sorry, didn't realize the docs were in the repo or I would have included in my PR.)

One other note: it's not clear that the sudos are necessary since all of the files affected should be owned by the current user.

@toolmantim
Copy link
Contributor

👍 No worries, they're a separate repo anyhoo. And I've removed those sudos now too, nice catch (again)

sj26 pushed a commit that referenced this pull request Feb 25, 2016
Update launchd templates to use .buildkite-agent dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants