Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-experimentify flock-file-locks #2131

Merged
merged 1 commit into from
May 31, 2023
Merged

De-experimentify flock-file-locks #2131

merged 1 commit into from
May 31, 2023

Conversation

DrJosh9000
Copy link
Contributor

As @moskyb wrote elsewhere:

when we release this, we should include a note that says that agents on this version will be incompatible with agents of other versions on the same instance sharing the same git repo - all agents will have to be upgraded at the same time, otherwise they won't see each other's locks

@DrJosh9000 DrJosh9000 force-pushed the pdp-944-deexperimentify-flock branch from 74d9945 to fa89a20 Compare May 31, 2023 06:06
@DrJosh9000 DrJosh9000 requested a review from a team May 31, 2023 06:09
@DrJosh9000 DrJosh9000 force-pushed the pdp-944-deexperimentify-flock branch from fa89a20 to 14279ca Compare May 31, 2023 06:12
moskyb
moskyb approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@moskyb moskyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐦‍⬛🐦🕊️📁🔒

moskyb
moskyb approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@moskyb moskyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐦‍⬛🐦🕊️📁🔒

@DrJosh9000 DrJosh9000 force-pushed the pdp-944-deexperimentify-flock branch from 14279ca to 46d5076 Compare May 31, 2023 06:14
@DrJosh9000 DrJosh9000 enabled auto-merge May 31, 2023 06:28
@DrJosh9000 DrJosh9000 merged commit 45f55b4 into main May 31, 2023
1 check passed
@DrJosh9000 DrJosh9000 deleted the pdp-944-deexperimentify-flock branch May 31, 2023 06:36
@lox
Copy link
Contributor

lox commented Jun 1, 2023

For what it's worth, flock's did not do what they said on the tin for us with workloads running inside docker containers (agent on host, bootstrap in containers). File locks did not survive outside of the containers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moskyb moskyb moskyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DrJosh9000 @lox @moskyb