Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to configure location of Job Log tmp file #2174

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

yhartanto
Copy link
Contributor

Extending from this job log tmp feature #1564

We need the ability to move job log files into a different folder than tmp to share them. This will allow us to use different containers between job and runner and pre-exit hooks for example.

Copy link
Contributor

@moskyb moskyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, the code here LGTM, but it's failing go fmt checks -- could you run go fmt ./... on your machine and commit the results?

@yhartanto
Copy link
Contributor Author

@moskyb thank you sir, I updated now.

@moskyb moskyb enabled auto-merge July 4, 2023 00:17
@moskyb moskyb merged commit a7cb9e4 into buildkite:main Jul 4, 2023
1 check passed
@yhartanto yhartanto deleted the job_log_tmp branch July 5, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants