Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plugin interpolation #2191

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Fix plugin interpolation #2191

merged 1 commit into from
Jul 10, 2023

Conversation

DrJosh9000
Copy link
Contributor

@DrJosh9000 DrJosh9000 commented Jul 10, 2023 •
edited

The bug is: Plugins was []Plugin, but *Plugin was the thing that was selfInterpolator, so interpolateAny never called *Plugin.interpolate. Changing Plugins to be []*Plugin neatly resolves that.

Plus various tweaks and comments on interpolation generally.

@moskyb was right about making interpolateAny generic, it was a matter of moving the type assertion.

@DrJosh9000 DrJosh9000 requested a review from a team July 10, 2023 01:15
@DrJosh9000 DrJosh9000 added the bug label Jul 10, 2023
@DrJosh9000
Fix plugin interpolation
e8e64bd 
And various tweaks and comments on interpolation generally.
moskyb
moskyb approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@moskyb moskyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moskyb was right

as usual 💅

(this looks great btw)

@DrJosh9000 DrJosh9000 merged commit 8e15020 into main Jul 10, 2023
1 check passed
@DrJosh9000 DrJosh9000 deleted the interp-o-matic branch July 10, 2023 04:13
@DrJosh9000 DrJosh9000 added yaml and removed signing labels Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moskyb moskyb moskyb approved these changes

Assignees
No one assigned
Labels
bug yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DrJosh9000 @moskyb