Add a job log length limit #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
log-limit
branch
2 times, most recently
from
81df96b
to
9f8dee9
Compare
pda
reviewed
Jul 10, 2023
DrJosh9000
changed the title
DrJosh9000
force-pushed
the
log-limit
branch
2 times, most recently
from
36c6dcd
to
6aa2978
Compare
DrJosh9000
commented
Aug 9, 2023
Comment on lines
+116
to
+120
| ls.logger.Warn("The job log has reached %s in size, which has "+ | ||
| "exceeded the maximum size (%s). Further logs may be dropped "+ | ||
| "by the server, and a future version of the agent will stop "+ | ||
| "sending logs at this point.", | ||
| humanize.Bytes(ls.bytes), humanize.Bytes(ls.conf.MaxSizeBytes)) |
There was a problem hiding this comment.
@matthewborden suggested this should just be a warning for now. Here's a cut of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since removing the need to hold the whole log in memory, there have been a few cases of long-running jobs logging lots of logs. This adds a (server-specified) limit, with a default of 1GiB.
Why not just limit it server side? Because the job itself should get some kind of pushback once it approaches or hits the limit. Returning errors when writing to the buffer feels like the right place.