Add experiment to avoid a recursive trap #2209
Merged
+25
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triarius
force-pushed
the
pdp-1326-implement-experiment-to-avoid-recursive-trap
branch
from
9cbdd8f
to
5ba40b9
Compare
DrJosh9000
reviewed
Jul 17, 2023
internal/job/executor.go
Outdated
| @@ -1966,10 +1976,19 @@ func (e *Executor) defaultCommandPhase(ctx context.Context) error { | |||
| return err | |||
| } | |||
|
|
|||
| // Update: The comment below is of dubious validity, because: | |||
There was a problem hiding this comment.
Might be better to incorporate or replace the dubious comment...
// The below is the "recursive trap".
// The original idea was to ...
// But ..., so we are phasing it out under an experiment.| // to show the error to users. | ||
| e.shell.Errorf("The command was interrupted by a signal: %v", commandErr) | ||
|
|
||
| // although error is an exit error, it's not returned. (seems like a bug) |
There was a problem hiding this comment.
(seems like a bug) seems like a bug.
triarius
deleted the
pdp-1326-implement-experiment-to-avoid-recursive-trap
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some jobs are run as a bash script of the form:
We now understand this causes a bug (see the code comments), and we want to avoid it.
This PR adds an experiment to avoid adding the trap to the script.