Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug where multiple map merges aren't unmarshaled into structs in the way we've supported them.
To address this we need to go back to having greater control over the YAML unmarshaling process. It will also help if we, say, want to switch YAML library later on - if a new library supports the things we need to do, then we can simplify, and if it doesn't (or has subtle differences) then the intermediate processing can be the place where we make up the gap.
The key change here is from allowing
yaml.v3
to unmarshal into structs using its reflective logic to:*yaml.Node
, which provides all the relevant information in the document without further processing.ordered
, which handles merges and aliases (including multiple merges).*ordered.MapSA
,[]any
, and basic types into each struct manually.The last manual part could be converted into a
yaml.v3
-like orencoding/json
-like reflection-based approach at some point.