Remove a double check for the existence of a local hook and log when it is missing in debug #2249
+12
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it is missing in debug I always have to do a double take when I read this code. But finally found a reason to remove it! `Executor.hasLocalHook` calls `Executor.localHookPath`, so in this method, `Executor.executeLocalHook`, we are calling `Executor.localHookPath` twice. This PR removes that and adds some logging to the job logs for when the hook is not found (in debug mode).
moskyb
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always have to do a double take when I read this code. But finally
found a reason to remove it!
Executor.hasLocalHookcallsExecutor.localHookPath, so in this method,Executor.executeLocalHook, we are callingExecutor.localHookPathtwice.This PR removes that and adds some logging to the job logs for when the hook
is not found (in debug mode).