Refactor some code in process.go #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended to be a no-op refactor. `errors.As` should work in more circumstances than the previous type assertion. Other than that, the order of the edge and main cases have been inverted, and the error message has been tweaked a little.
This means the goroutine is spun up when the context is nil when previously it would not be. This is fine because they are pretty cheap, and also it it is highly unlikely that the context will be nil at runtime.
triarius
force-pushed
the
pdp-1405-refactor-process-code
branch
from
8c3fda4
to
d471235
Compare
triarius
commented
Jul 30, 2023
| @@ -43,6 +43,10 @@ var signalMap = map[string]Signal{ | |||
| "SIGTERM": SIGTERM, | |||
| } | |||
|
|
|||
| var ErrNotWaitStatus = errors.New( | |||
| "unimplemented for systems where exec.ExitError.Sys() is not syscall.WaitStatus", | |||
There was a problem hiding this comment.
This error message is not helpful to users, so should not really be exposed except under debug. However, it is more or less what was there before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details available commit by commit