Add future-proofing UnknownStep type #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triarius
reviewed
Jul 31, 2023
There was a problem hiding this comment.
LGTM, but I also think we should backtrack errors from unmarshalling known step types and fall back to presenting the step as an UnknownStep then as well. It will mean we can't sign the step, though, so maybe we should refuse to sign pipelines with unknown steps and display an error message to contact support.
Something like this?
Definitely! |
triarius
approved these changes
Jul 31, 2023
DrJosh9000
force-pushed
the
futureproof-steps
branch
6 times, most recently
from
7a7641e
to
bd90d57
Compare
DrJosh9000
force-pushed
the
futureproof-steps
branch
from
bd90d57
to
cd012e3
Compare
DrJosh9000
force-pushed
the
futureproof-steps
branch
from
cd012e3
to
d024d13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It occurred to me that the new parser has no way of representing steps that we haven't invented yet.