Nil handling tweaks #2260
Merged
Nil handling tweaks #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moskyb
approved these changes
Jul 31, 2023
triarius
reviewed
Jul 31, 2023
DrJosh9000
force-pushed
the
nils-and-nulls
branch
4 times, most recently
from
50d11d3
to
af9a377
Compare
DrJosh9000
force-pushed
the
nils-and-nulls
branch
from
af9a377
to
330c09a
Compare
Added a parser test for The other thing I found while doing that is defensive/an unlikely edge case ( |
moskyb
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
env: null, and this should be handled appropriately.Steps.unmarshalAnyshould be skipped ifo == nil, not just if*s == nilalso.ToMapshould handle nil receiver (like all the other methods).