Remove unwrapping in error Is methods
#2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
reviewed
Aug 3, 2023
There was a problem hiding this comment.
While we're here, you could update Errors to be Unwrap that returns []error. I don't think any call sites of Errors use anything other than the Error method.
triarius
force-pushed
the
pdp-1424-fix-error-is-method-unwraps
branch
from
d0f5c92
to
2ee34ab
Compare
DrJosh9000
reviewed
Aug 3, 2023
Comment on lines
+43
to
+46
| out := make([]error, 0, len(errs)) | ||
| for i := range errs { | ||
| out = append(out, &errs[i]) | ||
| } |
There was a problem hiding this comment.
I guess the alternative is to make errs have type []error, then type-assert everything in the sort.Slice closure...
Hang on, does anything use the order of e.errs?
There was a problem hiding this comment.
I think it's nice for the user. I wrote tests for it, so they will break
There was a problem hiding this comment.
Hmm. Maybe I didn't 🤷♂️. Still think it's nice for the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was doing some "light reading" of the go standard library, and noticed this:
In the former implementations, calling
errors.Ascould unwrap the errors, so this PR fixes this.