Include plugins in command step signatures #2292
Conversation
| func (c *CommandStep) SignedFields() (map[string]string, error) { | ||
| plugins := "" | ||
| if len(c.Plugins) > 0 { | ||
| // TODO: Reconsider using JSON here - is it stable enough? |
There was a problem hiding this comment.
Ordered Maps are an issue, yeah? I think we can overcome it if we marshal all the unordered stuff into ordered equivalents.
Another one could be floating point representation, and precision. If the backend or database changes the precision of a number, we could have an issue.
There was a problem hiding this comment.
Ordered Maps are an issue, yeah? I think we can overcome it if we marshal all the unordered stuff into ordered equivalents.
My thinking on this is: the pipeline parser ultimately shoves whatever ordered.DecodeYAML produces for the plugin config into Plugin.Config, which will tend to be either *ordered.Map[string, any] or nil, preserving input order. As long as the backend does it the same, it should be equal.
Another one could be floating point representation, and precision. If the backend or database changes the precision of a number, we could have an issue.
This kind of thing does concern me.
Plugins alter the execution of a step completely, so the list of plugins and their configurations must be included in the signature for it to be secure.
This PR currently encodes plugin configs into JSON. This is potentially not a great encoding (what stability guarantees do we really have?), but because this is how the whole pipeline is uploaded, it ought to round-trip well enough.